Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 11953115: Add --generate-script-snapshot option to dart so that this binary can be used for generating script… (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add --generate-script-snapshot option to dart so that this binary can be used for generating script snapshots. Committed: https://code.google.com/p/dart/source/detail?r=17680

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -35 lines) Patch
M bin/main.cc View 1 5 chunks +95 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 11 months ago (2013-01-25 22:16:56 UTC) #1
Ivan Posva
LGTM with comment. -Ivan https://codereview.chromium.org/11953115/diff/1/bin/main.cc File bin/main.cc (right): https://codereview.chromium.org/11953115/diff/1/bin/main.cc#newcode175 bin/main.cc:175: if (snapshot_buffer == NULL) { ...
7 years, 11 months ago (2013-01-25 22:29:55 UTC) #2
siva
7 years, 11 months ago (2013-01-26 00:39:32 UTC) #3
https://codereview.chromium.org/11953115/diff/1/bin/main.cc
File bin/main.cc (right):

https://codereview.chromium.org/11953115/diff/1/bin/main.cc#newcode175
bin/main.cc:175: if (snapshot_buffer == NULL) {
On 2013/01/25 22:29:55, Ivan Posva wrote:
> Move this up to sit next to the corresponding comment?

Done.

https://codereview.chromium.org/11953115/diff/1/bin/main.cc#newcode210
bin/main.cc:210: { "--generate_script_snapshot=", ProcessGenScriptSnapshotOption
},
I have dropped generate_script_snapshot,
I will drop use_script_snapshot after I fix the dart2js script.

On 2013/01/25 22:29:55, Ivan Posva wrote:
> Why the duplication here?

Powered by Google App Engine
This is Rietveld 408576698