Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 11953076: Move code around in preparation for better inlining. (Closed)

Created:
7 years, 11 months ago by Kevin Millikin (Google)
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move code around in preparation for better inlining. To inlining calls in a test context, the code to plug the inlined function graph into the caller graph should be dispatched on the type of the inlining context. This change moves code around without otherwise changing it. Committed: https://code.google.com/p/dart/source/detail?r=17569

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -230 lines) Patch
M runtime/vm/flow_graph.h View 2 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -210 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 3 chunks +34 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +147 lines, -0 lines 1 comment Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Google)
7 years, 11 months ago (2013-01-24 13:16:32 UTC) #1
Florian Schneider
lgtm
7 years, 11 months ago (2013-01-24 14:10:14 UTC) #2
srdjan
DBC https://codereview.chromium.org/11953076/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/11953076/diff/1/runtime/vm/flow_graph_builder.cc#newcode63 runtime/vm/flow_graph_builder.cc:63: InliningContext* InliningContext::Create(Definition* call) { Why the argument call?
7 years, 11 months ago (2013-01-24 18:09:51 UTC) #3
Kevin Millikin (Google)
7 years, 10 months ago (2013-01-28 13:14:07 UTC) #4
Message was sent while issue was closed.
On 2013/01/24 18:09:51, srdjan wrote:

> Why the argument call?

It's not necessary yet.  In a future change, we will need to pattern match on
the call instruction to see what kind of inlining context to create from this
factory.

Powered by Google App Engine
This is Rietveld 408576698