Issue 11953048: Support 'implements' clause on typedef mixin applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11953048: Support 'implements' clause on typedef mixin applications. (Closed)

Created:
7 years, 11 months ago by kasperl

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support 'implements' clause on typedef mixin applications. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17528

Patch Set 1 #

Patch Set 2 : Remove obsolete test. #

Patch Set 3 : Fix unparser. #

Patch Set 4 : Rebase. #

Patch Set 5 : Pass the superclass. #

Patch Set 6 : Merge. #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -70 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/utils.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3 4	3 chunks	+51 lines, -40 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		3 chunks	+20 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View		3 chunks	+11 lines, -9 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View		3 chunks	+8 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/unparser.dart	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
A	tests/language/mixin_implements_test.dart	View		1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

7 years, 11 months ago (2013-01-24 08:33:17 UTC) #2

lgtm

https://codereview.chromium.org/11953048/diff/9009/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/scanner/parser.dart (left):

https://codereview.chromium.org/11953048/diff/9009/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/scanner/parser.dart:282: Token
parseMixinApplication(Token token, bool isTypedef) {
Good to get rid of this :)

Expand Messages | Collapse Messages