Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11953044: Do not eliminate instructions that might throw. (Closed)

Created:
7 years, 11 months ago by ngeoffray
Modified:
7 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not eliminate instructions that might throw. Committed: https://code.google.com/p/dart/source/detail?r=17446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ngeoffray
Fixes the bot redness.
7 years, 11 months ago (2013-01-23 10:24:31 UTC) #1
kasperl
LGTM.
7 years, 11 months ago (2013-01-23 10:29:05 UTC) #2
ahe
Did you have a test for this?
7 years, 11 months ago (2013-01-23 10:57:19 UTC) #3
ngeoffray
On 2013/01/23 10:57:19, ahe wrote: > Did you have a test for this? co19/LibTest/core/int/operator_right_shift_A01_t03 exactly ...
7 years, 11 months ago (2013-01-23 11:00:02 UTC) #4
ahe
On 2013/01/23 11:00:02, ngeoffray wrote: > On 2013/01/23 10:57:19, ahe wrote: > > Did you ...
7 years, 11 months ago (2013-01-23 11:33:03 UTC) #5
ngeoffray
On 2013/01/23 11:33:03, ahe wrote: > On 2013/01/23 11:00:02, ngeoffray wrote: > > On 2013/01/23 ...
7 years, 11 months ago (2013-01-23 12:03:07 UTC) #6
ahe
7 years, 11 months ago (2013-01-23 12:10:40 UTC) #7
Message was sent while issue was closed.
On 2013/01/23 12:03:07, ngeoffray wrote:
> My previous CL made it fail and it was pass before. The bot was red for a
> minute.

Thank you!

Powered by Google App Engine
This is Rietveld 408576698