Move cache consistency validation into Analysis Server.

Move cache consistency validation into Analysis Server.

This speeds up the add/analyze/remove/analyze cycle from 1600 ms to
1300 ms, i.e. on about 20%.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e9c3b2d7b1f8358384921ff0723f072cb09ed4d5

[Brian Wilkerson, 2015-06-21 15:52:39]

LGTM

https://codereview.chromium.org/1195183002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):

https://codereview.chromium.org/1195183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:247:
print('cacheIsInconsistent: $cacheIsInconsistent');
Remove debug line? If we want to capture this we should consider creating an
instrumentation hook for it.

https://codereview.chromium.org/1195183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:317: bool
_validateCacheConsistency() {
I'd move this method to AnalysisContext. I'd rather have a high-level method
like this exposed in the API rather than 'validateSourceCacheConsistency'.

[scheglov, 2015-06-22 15:09:06]

PTAL

[Brian Wilkerson, 2015-06-22 15:19:00]

LGTM

[scheglov, 2015-06-22 15:19:48]

Committed patchset #2 (id:20001) manually as
e9c3b2d7b1f8358384921ff0723f072cb09ed4d5 (presubmit successful).