Issue 1194653002: pull in new watcher package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1194653002: pull in new watcher package (Closed)

Created:
5 years, 6 months ago by danrubel

Modified:
5 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

pull in new watcher package BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/61460a0a1011aecdffeaaee2152e3cc4d6ee5e3e

Patch Set 2 : merge #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/1194653002/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/1194653002/diff/1/pkg/analyzer/pubspec.yaml#newcode13 pkg/analyzer/pubspec.yaml:13: watcher: '>=0.9.6 <0.10.0' This can be written as ...

5 years, 6 months ago (2015-06-18 20:25:49 UTC) #3

danrubel

5 years, 6 months ago (2015-06-20 18:12:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
61460a0a1011aecdffeaaee2152e3cc4d6ee5e3e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1194653002: pull in new watcher package (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge #

Messages