Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 11946042: Speed up web_socket_test by running subtests in parallel. (Closed)

Created:
7 years, 11 months ago by Bill Hesse
Modified:
7 years, 11 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Speed up web_socket_test by running subtests in parallel. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17218

Patch Set 1 #

Patch Set 2 : Remove pipelining and Futures. #

Total comments: 4

Patch Set 3 : Factor out common code from tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -728 lines) Patch
M tests/standalone/io/web_socket_no_secure_test.dart View 1 2 2 chunks +315 lines, -362 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 2 2 chunks +317 lines, -366 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
7 years, 11 months ago (2013-01-17 12:23:57 UTC) #1
Anders Johnsen
As discussed offline, I don't think we should pipeline tests at all. Up to you ...
7 years, 11 months ago (2013-01-17 12:41:57 UTC) #2
Bill Hesse
Removed pipelining.
7 years, 11 months ago (2013-01-17 12:59:38 UTC) #3
Anders Johnsen
LGTM https://codereview.chromium.org/11946042/diff/4001/tests/standalone/io/web_socket_test.dart File tests/standalone/io/web_socket_test.dart (right): https://codereview.chromium.org/11946042/diff/4001/tests/standalone/io/web_socket_test.dart#newcode20 tests/standalone/io/web_socket_test.dart:20: ReceivePort keepAlive = new ReceivePort(); The ReceivePorts are ...
7 years, 11 months ago (2013-01-17 14:17:33 UTC) #4
Bill Hesse
7 years, 11 months ago (2013-01-17 15:26:41 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698