Hide collection-dev library.

Hide collection-dev library.

Committed: https://code.google.com/p/dart/source/detail?r=18167
Reverted: https://code.google.com/p/dart/source/detail?r=18169

Committed: https://code.google.com/p/dart/source/detail?r=18172

[floitsch, 2013-01-18 23:40:14]

@Ivan: could you please confirm that hiding the collection-dev library is as
simple as not registering it.

(I will get reviews for the library and dart2js parts on Monday).

[Ivan Posva, 2013-01-23 04:13:51]

This hiding is rather ad-hoc and will break as soon as the VM starts including
the real files instead of preprocessed blocks of data.

-Ivan

[floitsch, 2013-01-30 21:36:54]

@ivan PTAL (the VM section) and tests. Do you want me to add a comment where the
line was?
@Johnni: please confirm that this is the right way to hide dart:_collection-dev.
@lrn: please review the move in general.

[Johnni Winther, 2013-01-30 21:52:22]

lgtm

[Lasse Reichstein Nielsen, 2013-01-31 10:09:21]

General move looks like it's just a move, but it's impossible to tell when you
don't get to compare moved files.
LGTM if the files are just moved with a name-update.

https://codereview.chromium.org/11938036/diff/4001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/11938036/diff/4001/tools/create_sdk.py#newcode28
tools/create_sdk.py:28: # ......_collection_dev/
Have you considered placing it under _internal?

[Ivan Posva, 2013-02-06 00:50:54]

Once the non-registering of the library is removed LGTM from the VM perspective.

-Ivan

https://codereview.chromium.org/11938036/diff/4001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11938036/diff/4001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:6253: const String& url =
String::Handle(Symbols::New("dart:_collection-dev"));
https://codereview.chromium.org/12220027 properly does implement private dart:_
libraries. Please revert this.

[floitsch, 2013-02-06 15:10:44]

@Konstantin: please have a look at the changes in dartc.
TBR.

[scheglov, 2013-02-06 17:39:16]

lgtm