Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1193653002: Add file modes for opening a file write only (Closed)

Created:
5 years, 6 months ago by Søren Gjesse
Modified:
4 years, 4 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add file modes for opening a file write only Added two new file modes WRITE_ONLY and WRITE_ONLY_APPEND. The current file modes WRITE and WRITE_APPEND are kept as the read/write mode with no change. Kept the same overall handling of create/truncate/append semantics for the new file modes. R=ager@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/eaeecf2ed13ba6c7fbfd653c3c592974a7120960

Patch Set 1 #

Patch Set 2 : Added Mac, Android and WIndows implementations #

Total comments: 1

Patch Set 3 : Addressed review comments + fixed analyzer reported issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -19 lines) Patch
M runtime/bin/file.h View 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/bin/file.cc View 1 chunk +9 lines, -1 line 0 comments Download
M runtime/bin/file_android.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M runtime/bin/file_linux.cc View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/bin/file_macos.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M runtime/bin/file_win.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M sdk/lib/io/file.dart View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 3 chunks +13 lines, -9 lines 0 comments Download
A tests/standalone/io/file_write_only_test.dart View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Søren Gjesse
5 years, 6 months ago (2015-06-18 11:34:22 UTC) #1
Søren Gjesse
On 2015/06/18 11:34:22, Søren Gjesse wrote: This is Linux only for now.
5 years, 6 months ago (2015-06-18 11:34:39 UTC) #2
Søren Gjesse
Now with Mac, Android and Windows.
5 years, 6 months ago (2015-06-18 11:41:23 UTC) #3
Mads Ager (google)
LGTM, thanks Soren! :) https://codereview.chromium.org/1193653002/diff/20001/sdk/lib/io/file.dart File sdk/lib/io/file.dart (right): https://codereview.chromium.org/1193653002/diff/20001/sdk/lib/io/file.dart#newcode42 sdk/lib/io/file.dart:42: const WRITE_ONLY = FileMode.WRITE_ONLY; You ...
5 years, 6 months ago (2015-06-18 12:04:48 UTC) #4
Søren Gjesse
Committed patchset #3 (id:40001) manually as eaeecf2ed13ba6c7fbfd653c3c592974a7120960 (presubmit successful).
5 years, 6 months ago (2015-06-18 13:19:33 UTC) #5
ahe
Thank you!
5 years, 6 months ago (2015-06-18 14:50:42 UTC) #6
kevmoo
5 years, 5 months ago (2015-06-30 21:31:05 UTC) #7
Message was sent while issue was closed.
On 2015/06/18 14:50:42, ahe wrote:
> Thank you!

Please update CHANGELOG.md for API changes.

Powered by Google App Engine
This is Rietveld 408576698