Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1193423002: dart2js: Avoid Object.create for bookeeping data structures during startup. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Avoid Object.create for bookeeping data structures during startup. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/1057e730193b9615bff610a1f9d742db82057435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
herhut
So, it turns out that for the artificial benchmark we had, we added objects to ...
5 years, 6 months ago (2015-06-22 14:49:55 UTC) #2
floitsch
LGTM. Did this yield any other speed improvements?
5 years, 6 months ago (2015-06-22 14:55:52 UTC) #3
herhut
5 years, 6 months ago (2015-06-23 08:38:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1057e730193b9615bff610a1f9d742db82057435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698