Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 11934004: Remove more classes and members by making them private. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski
Modified:
7 years, 11 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove more classes and members by making them private. Committed: https://code.google.com/p/dart/source/detail?r=17175

Patch Set 1 #

Patch Set 2 : Removing some stuff. #

Total comments: 8

Patch Set 3 : Code review changes. #

Patch Set 4 : Merged and stuff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -715 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 12 chunks +162 lines, -279 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 9 chunks +180 lines, -416 lines 0 comments Download
M tests/html/element_types_test.dart View 1 2 2 chunks +0 lines, -13 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 5 chunks +11 lines, -5 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrei Mouravski
Here are the remaining classes that need to be removed for now. Some members are ...
7 years, 11 months ago (2013-01-15 22:50:46 UTC) #1
blois
https://codereview.chromium.org/11934004/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11934004/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode23760 sdk/lib/html/dart2js/html_dart2js.dart:23760: static const EventStreamProvider<Event> beforeUnloadEvent = const EventStreamProvider<Event>('beforeunload'); Can you ...
7 years, 11 months ago (2013-01-15 23:05:55 UTC) #2
Andrei Mouravski
PTAL. https://codereview.chromium.org/11934004/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11934004/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode23760 sdk/lib/html/dart2js/html_dart2js.dart:23760: static const EventStreamProvider<Event> beforeUnloadEvent = const EventStreamProvider<Event>('beforeunload'); On ...
7 years, 11 months ago (2013-01-15 23:57:59 UTC) #3
blois
7 years, 11 months ago (2013-01-16 22:51:33 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698