Style guide acceptance tests.

Style guide acceptance tests.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31444

[Brian Wilkerson, 2014-01-03 01:06:47]

LGTM, after a couple of "improvements".

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
File pkg/analyzer/test/services/data/style_guide_tests.data (right):

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:9: Point(this.x, this.y);
Is there a way to disable code transformations so that the formatter only
formats code?

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:74: switches() {
The before and after code are the same, so this test could pass if the formatter
just copied the source verbatim.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:112: loop() {
The before and after code are the same.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:130: flow() {
You might want to test more cases (such as if and do-while).

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:154: spaces() {
The before code should include spaces in the wrong places so that we can ensure
they're being removed.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:188:
ListBox({this.showScrollbars: false});
You might want to add another named parameter that has a space before the ':'
but not after.

[pquitslund, 2014-01-03 19:02:16]

Thanks Brian!

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
File pkg/analyzer/test/services/data/style_guide_tests.data (right):

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:9: Point(this.x, this.y);
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> Is there a way to disable code transformations so that the formatter only
> formats code?

Yep.  A command-line a flag.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:74: switches() {
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> The before and after code are the same, so this test could pass if the
formatter
> just copied the source verbatim.

Tweaked.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:112: loop() {
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> The before and after code are the same.

Done.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:130: flow() {
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> You might want to test more cases (such as if and do-while).

Absolutely.  There are more in the "unit tests".  These examples are all taken
(nearly verbatim) from the  style guide and I'd like to keep the correlation
1:1.  Think of this group of tests more as a sanity check.  (And assurance that
we're following our own advice as detailed in the guide.)

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:154: spaces() {
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> The before code should include spaces in the wrong places so that we can
ensure
> they're being removed.

Done.

https://codereview.chromium.org/119323005/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/style_guide_tests.data:188:
ListBox({this.showScrollbars: false});
On 2014/01/03 01:06:47, Brian Wilkerson wrote:
> You might want to add another named parameter that has a space before the ':'
> but not after.

There's one like this in the unit tests.

[pquitslund, 2014-01-03 19:03:16]

Committed patchset #2 manually as r31444 (presubmit successful).