Next steps toward HTML support

Next steps toward HTML support

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c891a348abd07cae1ee185926dc22f55a5a51e9a

[Brian Wilkerson, 2015-06-20 15:45:12]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-06-20 16:46:51]

LGTM but we need to do something with dependencies.

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2720: //    int modificationTime =
getRequiredInput(MODIFICATION_TIME_INPUT_NAME);
Do you want to remove the commented code?

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3347: return <String, TaskInput>{};
A task cannot have empty inputs.

Inputs are used for dependency tracking.
No inputs - no dependencies, never removed from cache.

At the end we should be able to track down all the inputs to sources.

[Brian Wilkerson, 2015-06-21 15:52:34]

PTAL

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2720: //    int modificationTime =
getRequiredInput(MODIFICATION_TIME_INPUT_NAME);
Done

https://codereview.chromium.org/1193143002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3347: return <String, TaskInput>{};
Good point. I've added a dependency.

[scheglov, 2015-06-21 16:12:05]

LGTM

[Brian Wilkerson, 2015-06-21 16:21:48]

Committed patchset #2 (id:20001) manually as
c891a348abd07cae1ee185926dc22f55a5a51e9a (presubmit successful).