Move many iterable classes to collection_dev.

Move many iterable classes to collection_dev.

Committed: https://code.google.com/p/dart/source/detail?r=17276

[floitsch, 2013-01-17 17:21:34]

Based on https://codereview.chromium.org/11959012/

@Ivan: please have a look at the VM changes.

[Ivan Posva, 2013-01-17 18:36:12]

LGTM with comment.

-Ivan

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
File sdk/lib/collection_dev/iterable.dart (right):

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
sdk/lib/collection_dev/iterable.dart:15: MappedIterable(this._iterable, T
this._f(S element));
I find this notation very confusing (see the offline discussion) as there is a
particular typedef for this type already.

[Lasse Reichstein Nielsen, 2013-01-18 11:38:25]

lgtm

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
File sdk/lib/collection_dev/iterable.dart (right):

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
sdk/lib/collection_dev/iterable.dart:15: MappedIterable(this._iterable, T
this._f(S element));
I generally try to avoid this.f for functions too, and never use types with a
this.param unless it is different from the field's type (in the rare case where
your field is more general than some of your constructors).


I also avoid using this._foo for private fields since it becomes the name of the
parameter in the documentation, and you want another name here.

So maybe make it "Iterable<S> source, T mapping(S element)) : _iterable =
source, _f = mapping;".

[floitsch, 2013-01-18 12:29:15]

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
File sdk/lib/collection_dev/iterable.dart (right):

https://codereview.chromium.org/11931042/diff/1/sdk/lib/collection_dev/iterab...
sdk/lib/collection_dev/iterable.dart:15: MappedIterable(this._iterable, T
this._f(S element));
On 2013/01/18 11:38:25, Lasse Reichstein Nielsen wrote:
> I generally try to avoid this.f for functions too, and never use types with a
> this.param unless it is different from the field's type (in the rare case
where
> your field is more general than some of your constructors).
> 
> 
> I also avoid using this._foo for private fields since it becomes the name of
the
> parameter in the documentation, and you want another name here.
> 
> So maybe make it "Iterable<S> source, T mapping(S element)) : _iterable =
> source, _f = mapping;".

I will do it in a separate CL.