Unbreak local browser testing.

Unbreak local browser testing.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17176

[Jennifer Messerly, 2013-01-16 20:03:44]

lgtm, but I would like to hear Peter's input

https://codereview.chromium.org/11931025/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11931025/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:10: import
'temp_package_root/args/args.dart';
Shouldn't be done in this change, but I wanted to ask:

Can we rename this to directory "vendored_pkg" or something similar?

Also, can we add a README explaining why we have a copy of these packages?

Finally, if it is a problem to depend on something outside of "tools/testing",
how can we get the tests/build bots set up to catch that problem if it is
introduced again in the future?

[ahe, 2013-01-16 20:49:54]

Thank you, Emily!

LGTM

https://codereview.chromium.org/11931025/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/11931025/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:10: import
'temp_package_root/args/args.dart';
On 2013/01/16 20:03:44, John Messerly wrote:
> Shouldn't be done in this change, but I wanted to ask:
> 
> Can we rename this to directory "vendored_pkg" or something similar?

Perhaps we could just rewrite this program to take a fixed number of arguments.
It would simplify updating tools/testing/bin/OS/dart to not also have to update
a copy of pkg.

> Finally, if it is a problem to depend on something outside of "tools/testing",
> how can we get the tests/build bots set up to catch that problem if it is
> introduced again in the future?

I stated in a different conversation that it would be hard to test. But that's
because my natural reaction is to use something like dart2js to find all the
imports. But this could get broken as soon as dart2js got out of sync with
tools/testing/bin/OS/dart.

However, a simple test that just uses dart:io to scan the dart files in
tools/testing/dart would work.