Adding support for the MouseWheel event in Streams.

Adding support for the MouseWheel event in Streams.

In order to test this I also needed to add a constructor for the MouseWheel event, which complicated things.

In general, wheel events are incredibly fragmented across browsers.

BUG=7919
Committed: https://code.google.com/p/dart/source/detail?r=17172

[Siggi Cherem (dart-lang), 2013-01-16 18:52:00]

probably my comments should be in the templates and not in the generated code,
but it probably still appies

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21816: EventTarget relatedTarget = null])
{
generally indentation here looks strange. Consider combining these 16 lines into
a couple? (same below on the method calls)

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21854: else if (_Device.isIE) {
move else to previous line?

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21881: modifiersList,
nit: maybe simply inline modifiers.join(' ') here?

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:25718: typedef String
_EventTypeGetter(EventTarget target);
did you mean to use this type somewhere? (e.g. field of
_CustomEventStreamProvider?

https://codereview.chromium.org/11931009/diff/11001/tests/html/wheelevent_tes...
File tests/html/wheelevent_test.dart (right):

https://codereview.chromium.org/11931009/diff/11001/tests/html/wheelevent_tes...
tests/html/wheelevent_test.dart:1: library wheel_event_test;
+ copyright header

[blois, 2013-01-16 20:04:02]

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21816: EventTarget relatedTarget = null])
{
On 2013/01/16 18:52:00, Siggi Cherem (dart-lang) wrote:
> generally indentation here looks strange. Consider combining these 16 lines
into
> a couple? (same below on the method calls)

Updated. In general I find the collapsed form fairly unreadable for long lists,
but that is the convention.

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21854: else if (_Device.isIE) {
On 2013/01/16 18:52:00, Siggi Cherem (dart-lang) wrote:
> move else to previous line?

Was a by-product of template expansion, updated with new format in later patch.

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:21881: modifiersList,
On 2013/01/16 18:52:00, Siggi Cherem (dart-lang) wrote:
> nit: maybe simply inline modifiers.join(' ') here?

Done.

https://codereview.chromium.org/11931009/diff/9001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:25718: typedef String
_EventTypeGetter(EventTarget target);
On 2013/01/16 18:52:00, Siggi Cherem (dart-lang) wrote:
> did you mean to use this type somewhere? (e.g. field of
> _CustomEventStreamProvider?

Yes, but dart2js checked mode issue blocked it. removed.

[Siggi Cherem (dart-lang), 2013-01-16 21:46:42]

lgtm Thanks!

https://codereview.chromium.org/11931009/diff/2003/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_WheelEvent.darttemplate (right):

https://codereview.chromium.org/11931009/diff/2003/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate:154: String type,
nit: ditto here on the convention