Issue 11929037: Add test skeletons for arm and mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11929037: Add test skeletons for arm and mips. (Closed)

Created:
7 years, 11 months ago by regis

Modified:
7 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add test skeletons for arm and mips. Committed: https://code.google.com/p/dart/source/detail?r=17330

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+480 lines, -0 lines)			Patch
A	runtime/vm/assembler_arm_test.cc	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_mips_test.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	runtime/vm/code_patcher_arm_test.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	runtime/vm/code_patcher_mips_test.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	runtime/vm/instructions_arm_test.cc	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	runtime/vm/instructions_mips_test.cc	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	runtime/vm/stub_code_arm_test.cc	View		1 chunk	+89 lines, -0 lines	0 comments	Download
A	runtime/vm/stub_code_mips_test.cc	View		1 chunk	+89 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		5 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11929037/diff/1/runtime/vm/assembler_arm_test.cc File runtime/vm/assembler_arm_test.cc (right): https://codereview.chromium.org/11929037/diff/1/runtime/vm/assembler_arm_test.cc#newcode1 runtime/vm/assembler_arm_test.cc:1: // Copyright (c) 2012, the Dart project authors. ...

7 years, 11 months ago (2013-01-18 23:42:27 UTC) #2

regis

7 years, 11 months ago (2013-01-18 23:47:00 UTC) #3

Message was sent while issue was closed.

Thanks

https://codereview.chromium.org/11929037/diff/1/runtime/vm/assembler_arm_test.cc
File runtime/vm/assembler_arm_test.cc (right):

https://codereview.chromium.org/11929037/diff/1/runtime/vm/assembler_arm_test...
runtime/vm/assembler_arm_test.cc:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
On 2013/01/18 23:42:27, srdjan wrote:
> 2013

Done.

Expand Messages | Collapse Messages

Issue 11929037: Add test skeletons for arm and mips. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages