Issue 11929021: Optimize double.floor and double.ceil down to roundsd when SSE4.1 is available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11929021: Optimize double.floor and double.ceil down to roundsd when SSE4.1 is available. (Closed)

Created:
7 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Optimize double.floor and double.ceil down to roundsd when SSE4.1 is available. R=fschneider@google.com BUG=dart:7971 Committed: https://code.google.com/p/dart/source/detail?r=17278

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -11 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+17 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+17 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Florian Schneider

7 years, 11 months ago (2013-01-18 14:15:02 UTC) #2

LGTM.

Please add the corresponding test cases that we already have for round() also
for floor and ceil (from tests/language/arithmetic_test.dart)