Issue 1191883003: Fix Dartium/drt buildbots for recent conditional operator and prefix tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191883003: Fix Dartium/drt buildbots for recent conditional operator and prefix tests. (Closed)

Created:
5 years, 6 months ago by Paul Berry

Modified:
5 years, 6 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Dartium/drt buildbots for recent conditional operator and prefix tests. TBR=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/a2a93750f662fd7f75c61c8d0d6921dbb6a5ebb1

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	tests/language/language.status	View		2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 (id:1) manually as a2a93750f662fd7f75c61c8d0d6921dbb6a5ebb1 (presubmit successful).

5 years, 6 months ago (2015-06-18 23:14:03 UTC) #1

hausner

Thank you. LGTM. It confuses me that some tests that fail in the VM pass ...

5 years, 6 months ago (2015-06-18 23:23:47 UTC) #2

Paul Berry

5 years, 6 months ago (2015-06-19 00:01:31 UTC) #3

Message was sent while issue was closed.

On 2015/06/18 23:23:47, hausner wrote:
> Thank you. LGTM.
> 
> It confuses me that some tests that fail in the VM pass in dartium.
> For example (from Dartium buildbot run):
> 
> conditional_method_invocation_test/11
> Expected: Fail 
> Actual: Pass
> 
> The VM fails to produce a compile-time error, yet under dartium the test
passes
> even though the VM issues a runtime-error.

Yeah, I don't understand either.  Fortunately my experience has been that once
the VM implementation is correct, Dartium seems to do the right thing.  So
hopefully once the VM passes these tests Dartium will too and we won't have to
worry about it.

Thanks for the review.

Expand Messages | Collapse Messages