Assert no VM handles are created in the zone that belongs to a ApiNativeScopes.

Assert no VM handles are created in the zone that belongs to a ApiNativeScope.

Update snapshot_test, which was violating this principle.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/649719278a83f31e8fa141d0ae568ae5dddff252

[koda, 2015-06-17 18:02:19]

koda@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-06-19 23:30:46]

LGTM with one comment.

https://codereview.chromium.org/1191443008/diff/40001/runtime/vm/snapshot_tes...
File runtime/vm/snapshot_test.cc (right):

https://codereview.chromium.org/1191443008/diff/40001/runtime/vm/snapshot_tes...
runtime/vm/snapshot_test.cc:1599: Object* tmp_handle) {
Why is it not Ok to allocate the StackZone here instead of passing in a handle
pointer, We are calling Dart_Invoke and it could potentially also create
handles.

[koda, 2015-06-22 17:18:51]

https://codereview.chromium.org/1191443008/diff/40001/runtime/vm/snapshot_tes...
File runtime/vm/snapshot_test.cc (right):

https://codereview.chromium.org/1191443008/diff/40001/runtime/vm/snapshot_tes...
runtime/vm/snapshot_test.cc:1599: Object* tmp_handle) {
On 2015/06/19 23:30:46, siva wrote:
> Why is it not Ok to allocate the StackZone here instead of passing in a handle
> pointer, We are calling Dart_Invoke and it could potentially also create
> handles.

That would make the return value a dangling pointer.

It's true that Dart_Invoke does allocate handles, and it turns out my assertion
did not catch this. The issue is really that the ApiNativeScope should *only* be
around the deserialization (since everything else might allocate handles).

I've updated the CL substantially by:

1. splitting this helper method to allow smaller ApiNativeScopes in the test.
2. adding an ASSERT in handle allocation

PTAL

[siva, 2015-06-22 21:39:03]

lgtm

[koda, 2015-06-23 00:19:10]

Committed patchset #4 (id:60001) manually as
649719278a83f31e8fa141d0ae568ae5dddff252 (presubmit successful).