Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1191133002: UI for setting/clearing closure-specific breakpoints. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -8 lines) Patch
M runtime/observatory/lib/src/elements/instance_view.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/ports.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 1 2 8 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 1 chunk +28 lines, -6 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 6 months ago (2015-06-18 19:58:07 UTC) #2
Cutch
LGTM after adding a service test
5 years, 6 months ago (2015-06-18 20:18:09 UTC) #3
rmacnak
On 2015/06/18 20:18:09, Cutch wrote: > LGTM after adding a service test Added checks in ...
5 years, 6 months ago (2015-06-18 21:00:36 UTC) #4
rmacnak
5 years, 6 months ago (2015-06-18 21:01:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
723334d34450781375098c9e64638424dbe4ddb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698