Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1190413006: Fix line width issue. (Closed)

Created:
5 years, 6 months ago by siva
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 23646 https://github.com/dart-lang/sdk/issues/23646 Allow an ApiError or CompilationError to be passed into Dart_NewUnhandledExceptionError and use the error message in these objects as the Dart instance to throw. BUG=23646 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e9de48f49a0e17f236436e6ed1ad1ddfe8c774f5

Patch Set 1 #

Total comments: 6

Patch Set 2 : address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M runtime/include/dart_api.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 6 months ago (2015-06-19 23:19:10 UTC) #2
rmacnak
lgtm w/ comment https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc#newcode461 runtime/vm/dart_api_impl_test.cc:461: EXPECT(Dart_IsString(Dart_ErrorGetException(exception_error))); https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc#newcode470 runtime/vm/dart_api_impl_test.cc:470: Ditto https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc#newcode486 runtime/vm/dart_api_impl_test.cc:486: ...
5 years, 6 months ago (2015-06-19 23:26:10 UTC) #3
siva
https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc#newcode461 runtime/vm/dart_api_impl_test.cc:461: On 2015/06/19 23:26:10, rmacnak wrote: > EXPECT(Dart_IsString(Dart_ErrorGetException(exception_error))); Done. https://codereview.chromium.org/1190413006/diff/1/runtime/vm/dart_api_impl_test.cc#newcode470 ...
5 years, 6 months ago (2015-06-19 23:43:45 UTC) #4
siva
5 years, 6 months ago (2015-06-19 23:55:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e9de48f49a0e17f236436e6ed1ad1ddfe8c774f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698