Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1190143003: Fix for issue 23647 (https://github.com/dart-lang/sdk/issues/23647) (Closed)

Created:
5 years, 6 months ago by siva
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 23647 (https://github.com/dart-lang/sdk/issues/23647) Do not use VM isolate indexes when writing out references to objects in the VM isolate. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/321d34adad24af8262826ae8efcea4938b7aae1f

Patch Set 1 #

Patch Set 2 : Address self review comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -27 lines) Patch
M runtime/vm/raw_object.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 5 chunks +26 lines, -15 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +80 lines, -12 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 6 months ago (2015-06-18 20:01:27 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/1190143003/diff/20001/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/1190143003/diff/20001/runtime/vm/snapshot.cc#newcode1380 runtime/vm/snapshot.cc:1380: if (object_id != -1) { kInvalidIndex https://codereview.chromium.org/1190143003/diff/20001/runtime/vm/snapshot.cc#newcode1742 runtime/vm/snapshot.cc:1742: ...
5 years, 6 months ago (2015-06-18 20:34:55 UTC) #3
siva
5 years, 6 months ago (2015-06-19 17:58:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
321d34adad24af8262826ae8efcea4938b7aae1f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698