Noopt work: populate empty ICData of getters and setters with function's own class if that getter/s…

Noopt work: populate empty ICData of getters and setters with function's own class if that getter/setter exists in the class.

Significant performance improvements in DeltaBlue and Richards. No difference in dart2js except the size of Instructions went up by 12%.

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/cde9099e31c037d156b64da8fa6a5dcc73bf8e36

[srdjan, 2015-06-17 23:24:18]

srdjan@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2015-06-18 15:51:10]

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:239: return false;
This return makes the code below unreachable.

Make sure the code below is reachable and also tested.

[srdjan, 2015-06-18 16:16:06]

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:239: return false;
On 2015/06/18 15:51:10, Florian Schneider wrote:
> This return makes the code below unreachable.
> 
> Make sure the code below is reachable and also tested.

Oops, uploaded a cl with the performance testing experiment. All tests are run
without this 'return false'.

[Florian Schneider, 2015-06-18 17:34:37]

LGTM.

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1190123002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:239: return false;
On 2015/06/18 16:16:06, srdjan wrote:
> On 2015/06/18 15:51:10, Florian Schneider wrote:
> > This return makes the code below unreachable.
> > 
> > Make sure the code below is reachable and also tested.
> 
> Oops, uploaded a cl with the performance testing experiment. All tests are run
> without this 'return false'.

Ok.

[srdjan, 2015-06-18 17:56:35]

Committed patchset #3 (id:40001) manually as
cde9099e31c037d156b64da8fa6a5dcc73bf8e36 (presubmit successful).