Issue 1189983004: Fix in-test (missing parenthesis).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1189983004: Fix in-test (missing parenthesis). (Closed)

Created:
5 years, 6 months ago by floitsch

Modified:
5 years, 6 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix in-test (missing parenthesis). IE does not have a "name" field on functions. Therefore we set it, if it's missing. However, the test doing that ("name" in constructor) was not using the right precedences. Fixes #23623. BUG= http://dartbug.com/23623 R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/0b7b7d156c412a71d4725cf10f588a6264cd1afd

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

CCing Siggi because of test-coverage: do we want to run CSP tests on IE bots ...

5 years, 6 months ago (2015-06-17 13:06:17 UTC) #2

floitsch

Committed patchset #1 (id:1) manually as 0b7b7d156c412a71d4725cf10f588a6264cd1afd (presubmit successful).

5 years, 6 months ago (2015-06-17 13:54:48 UTC) #4

Siggi Cherem (dart-lang)

5 years, 6 months ago (2015-06-17 16:18:41 UTC) #5

Message was sent while issue was closed.

On 2015/06/17 13:06:17, floitsch wrote:
> CCing Siggi because of test-coverage: do we want to run CSP tests on IE bots
> too?
> Most of the time CSP is used for chrome-extensions, but we should probably run
> at least a few tests for IE too.

seems like a good idea. Filed: https://github.com/dart-lang/sdk/issues/23662

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages