Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 11896057: Issue 7605. Check separately getters and setter implementation when check for abstratc members. (Closed)

Created:
7 years, 11 months ago by scheglov
Modified:
7 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 7605. Check separately getters and setter implementation when check for abstratc members. http://code.google.com/p/dart/issues/detail?id=7605 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -41 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +0 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 5 chunks +35 lines, -22 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 8 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
7 years, 11 months ago (2013-01-23 06:26:26 UTC) #1
Brian Wilkerson
7 years, 11 months ago (2013-01-23 14:55:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698