Issue 11896038: Some more refactorings of overload dispatcher generation.

Issue 11896038: Some more refactorings of overload dispatcher generation. (Closed)

Created:
7 years, 11 months ago by Anton Muhin

Modified:
7 years, 11 months ago

Reviewers:
podivilov, Emily Fortuna, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Some more refactorings of overload dispatcher generation. R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=17522

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -120 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		6 chunks	+12 lines, -40 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		21 chunks	+21 lines, -0 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	4 chunks	+11 lines, -22 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1	4 chunks	+33 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	3 chunks	+10 lines, -28 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1	2 chunks	+5 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

minor formatting https://codereview.chromium.org/11896038/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/11896038/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode201 tools/dom/scripts/htmldartgenerator.py:201: (stmts_emitter, call_emitter) = body_emitter.Emit('$!A$!B', INDENT=' '); 80 ...

7 years, 11 months ago (2013-01-22 19:16:40 UTC) #2

Anton Muhin

ptal https://codereview.chromium.org/11896038/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/11896038/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode201 tools/dom/scripts/htmldartgenerator.py:201: (stmts_emitter, call_emitter) = body_emitter.Emit('$!A$!B', INDENT=' '); On 2013/01/22 ...

7 years, 11 months ago (2013-01-23 08:16:51 UTC) #3

lgtm

Expand Messages | Collapse Messages