Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1189543003: Ports page for isolates (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ports page for isolates Per isolate list of open ports and their handler R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/851ef4a4af6526fd9ec60147d32a6fd2d2c3135d

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -2 lines) Patch
M runtime/observatory/lib/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 chunk +5 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/ports.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/ports.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/web/main.dart View 2 chunks +3 lines, -1 line 2 comments Download
M runtime/vm/port.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/port.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-18 15:03:37 UTC) #2
rmacnak
lgtm w/ comment https://codereview.chromium.org/1189543003/diff/20001/runtime/observatory/web/main.dart File runtime/observatory/web/main.dart (right): https://codereview.chromium.org/1189543003/diff/20001/runtime/observatory/web/main.dart#newcode5 runtime/observatory/web/main.dart:5: import 'dart:async'; Unused?
5 years, 6 months ago (2015-06-18 17:01:44 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as 851ef4a4af6526fd9ec60147d32a6fd2d2c3135d (presubmit successful).
5 years, 6 months ago (2015-06-18 17:24:33 UTC) #4
Cutch
5 years, 6 months ago (2015-06-18 17:26:27 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1189543003/diff/20001/runtime/observatory/web...
File runtime/observatory/web/main.dart (right):

https://codereview.chromium.org/1189543003/diff/20001/runtime/observatory/web...
runtime/observatory/web/main.dart:5: import 'dart:async';
On 2015/06/18 17:01:44, rmacnak wrote:
> Unused?

Done.

Powered by Google App Engine
This is Rietveld 408576698