Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1188973003: Port "Add snapshoting methods for code's metadata." (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port "Add snapshoting methods for code's metadata." Adjust for field removed from PcDescriptors. Add SnapshotReader/Writer::allow_code(). R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/44d9f60dbf18a8df4ab2a586528e6cae8c623bd9

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -12 lines) Patch
M runtime/vm/object.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +76 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 4 chunks +143 lines, -12 lines 0 comments Download
M runtime/vm/snapshot.h View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
Untested, as we don't yet have code to snapshot.
5 years, 6 months ago (2015-06-18 00:38:33 UTC) #2
srdjan
lgtm https://chromiumcodereview.appspot.com/1188973003/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://chromiumcodereview.appspot.com/1188973003/diff/1/runtime/vm/object.h#newcode3819 runtime/vm/object.h:3819: static RawPcDescriptors* New(int32_t length); intptr_t
5 years, 6 months ago (2015-06-18 21:02:52 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1188973003/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://chromiumcodereview.appspot.com/1188973003/diff/1/runtime/vm/object.h#newcode3819 runtime/vm/object.h:3819: static RawPcDescriptors* New(int32_t length); On 2015/06/18 21:02:51, srdjan wrote: ...
5 years, 6 months ago (2015-06-19 17:21:51 UTC) #4
rmacnak
5 years, 6 months ago (2015-06-19 17:31:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
44d9f60dbf18a8df4ab2a586528e6cae8c623bd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698