Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 11889036: Enable WebSocket secure connection using "wss" in W3C interface. Add testing of secure WebSocket co… (Closed)

Created:
7 years, 11 months ago by Bill Hesse
Modified:
7 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable WebSocket secure connection using "wss" in W3C interface. Add testing of secure WebSocket connection for multiple websocket tests. BUG= TEST=standalone/io/web_socket_test.dart Committed: https://code.google.com/p/dart/source/detail?r=17074

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -47 lines) Patch
M sdk/lib/io/websocket_impl.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 16 chunks +133 lines, -45 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
I also serialized all the tests in web_socket_test using Futures. This wasn't strictly necessary, since ...
7 years, 11 months ago (2013-01-15 14:22:13 UTC) #1
Bill Hesse
On 2013/01/15 14:22:13, Bill Hesse wrote: > I also serialized all the tests in web_socket_test ...
7 years, 11 months ago (2013-01-15 14:23:36 UTC) #2
Søren Gjesse
7 years, 11 months ago (2013-01-15 14:53:33 UTC) #3
lgtm

https://codereview.chromium.org/11889036/diff/1/tests/standalone/io/web_socke...
File tests/standalone/io/web_socket_test.dart (right):

https://codereview.chromium.org/11889036/diff/1/tests/standalone/io/web_socke...
tests/standalone/io/web_socket_test.dart:15: // We will run the tests once over
HTTP and once over HTTPS
End comment with .

Powered by Google App Engine
This is Rietveld 408576698