Issue 11889006: Mark language/arithmetic_test as failing on runtime=ie9 compiler=dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11889006: Mark language/arithmetic_test as failing on runtime=ie9 compiler=dart2js (Closed)

Created:
7 years, 11 months ago by ricow1

Modified:
7 years, 11 months ago

Reviewers:
ahe, srdjan, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark language/arithmetic_test as failing on runtime=ie9 compiler=dart2js I can't find any bug for this, and I don't see any dart2js people on the codereview disabling this on ff, is this a known problem? Committed: https://code.google.com/p/dart/source/detail?r=17012

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/language/language_dart2js.status	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

7 years, 11 months ago (2013-01-14 08:35:17 UTC) #2

LGTM, but we should really have split the arithmetic test into two -- one with
the stuff that used to pass and the new stuff added in
http://code.google.com/p/dart/source/detail?r=16983.

Expand Messages | Collapse Messages