Issue 11888013: Adding support checks for FileSystem APIs and making APIs not webkit-specific.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11888013: Adding support checks for FileSystem APIs and making APIs not webkit-specific. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding support checks for FileSystem APIs and making APIs not webkit-specific. This is an updated version of https://codereview.chromium.org/11856014/ which was failing because the test was causing a timeout when file APIs are not supported. The first patch is the original, second is the updated version. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17037

Patch Set 1 #

Patch Set 2 : Fixing test. #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -71 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+18 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		3 chunks	+21 lines, -6 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View	1	2 chunks	+78 lines, -55 lines	2 comments	Download
M	tests/html/html.status	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View		3 chunks	+13 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

excellent! lgtm! https://codereview.chromium.org/11888013/diff/2001/tests/html/fileapi_test.dart File tests/html/fileapi_test.dart (right): https://codereview.chromium.org/11888013/diff/2001/tests/html/fileapi_test.dart#newcode99 tests/html/fileapi_test.dart:99: }); nit: I think this should be ...

7 years, 11 months ago (2013-01-14 23:28:03 UTC) #2

blois

7 years, 11 months ago (2013-01-14 23:45:10 UTC) #3

https://codereview.chromium.org/11888013/diff/2001/tests/html/fileapi_test.dart
File tests/html/fileapi_test.dart (right):

https://codereview.chromium.org/11888013/diff/2001/tests/html/fileapi_test.da...
tests/html/fileapi_test.dart:99: });
On 2013/01/14 23:28:03, Emily Fortuna wrote:
> nit: I think this should be indented two spaces less

The joys of closures, changing these APIs to futures should make it better.

I believe the indent is correct- all indents are 2 spaces except for the method
split across multiple lines which is 4.

Expand Messages | Collapse Messages