Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11887015: Add dart2js unittest to analyze the API. (Closed)

Created:
7 years, 11 months ago by Johnni Winther
Modified:
7 years, 11 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dart2js unittest to analyze the API. Committed: https://code.google.com/p/dart/source/detail?r=17574

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased + test added #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A tests/compiler/dart2js/analyze_api_test.dart View 1 2 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
7 years, 11 months ago (2013-01-14 11:51:25 UTC) #1
kasperl
https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode16 sdk/lib/html/dart2js/html_dart2js.dart:16: // DO NOT EDIT This file is generated. Editing ...
7 years, 11 months ago (2013-01-15 07:25:20 UTC) #2
Johnni Winther
https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode16 sdk/lib/html/dart2js/html_dart2js.dart:16: // DO NOT EDIT On 2013/01/15 07:25:20, kasperl wrote: ...
7 years, 11 months ago (2013-01-15 07:55:41 UTC) #3
kasperl
https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode16 sdk/lib/html/dart2js/html_dart2js.dart:16: // DO NOT EDIT On 2013/01/15 07:55:41, Johnni Winther ...
7 years, 11 months ago (2013-01-15 08:43:47 UTC) #4
Johnni Winther
PTAL Test added. https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/html_common/filtered_element_list.dart File sdk/lib/html/html_common/filtered_element_list.dart (right): https://codereview.chromium.org/11887015/diff/1/sdk/lib/html/html_common/filtered_element_list.dart#newcode129 sdk/lib/html/html_common/filtered_element_list.dart:129: elementAt(int index) { On 2013/01/15 07:25:20, ...
7 years, 11 months ago (2013-01-15 11:30:10 UTC) #5
ahe
7 years, 11 months ago (2013-01-21 12:24:57 UTC) #6 
LGTM, nice test!

Powered by Google App Engine
This is Rietveld 408576698