Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1188613008: Fix timing issue in stream_empty_test, and make analyzer expect it to pass. (Closed)

Created:
5 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix timing issue in stream_empty_test, and make analyzer expect it to pass. Committed: https://github.com/dart-lang/sdk/commit/80960767e9e8734671164752c100157319cd1edc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tests/lib/async/stream_empty_test.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
TBR
5 years, 6 months ago (2015-06-16 11:33:24 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 80960767e9e8734671164752c100157319cd1edc (presubmit successful).
5 years, 6 months ago (2015-06-16 11:34:38 UTC) #3
Søren Gjesse
5 years, 6 months ago (2015-06-16 11:54:53 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698