Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11886064: Removed the 'we don't run multitests on browsers'-hack (Closed)

Created:
7 years, 11 months ago by kustermann
Modified:
7 years, 11 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed the 'we don't run multitests on browsers'-hack Committed: https://code.google.com/p/dart/source/detail?r=17183

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tests/language/language.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
7 years, 11 months ago (2013-01-16 10:21:04 UTC) #1
ahe
Did you test this on Dartium? It still wraps tests as far as I know, ...
7 years, 11 months ago (2013-01-16 10:27:36 UTC) #2
kustermann
On 2013/01/16 10:27:36, ahe wrote: > Did you test this on Dartium? It still wraps ...
7 years, 11 months ago (2013-01-16 10:29:53 UTC) #3
ahe
On 2013/01/16 10:29:53, kustermann wrote: > On 2013/01/16 10:27:36, ahe wrote: > > Did you ...
7 years, 11 months ago (2013-01-16 10:37:47 UTC) #4
kustermann
I did run the following tests: ./tools/test.py -mrelease -cnone -rvm --report --time ./tools/test.py -mrelease -cnone ...
7 years, 11 months ago (2013-01-16 17:54:55 UTC) #5
ahe
7 years, 11 months ago (2013-01-16 17:57:25 UTC) #6
Awesome, thank you!

LGTM

https://codereview.chromium.org/11886064/diff/2002/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11886064/diff/2002/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1311: new RegExp("^(#?source|#?import|part)[
\t]+[\('\"]", multiLine: true);
On 2013/01/16 17:54:55, kustermann wrote:
> This was broken before. After correcting this we'll get sometimes warnings:
>  "Warning for somefile.dart: Browser tests require #library in any file that
> uses #import, #source, or #resource"
> 
> The reason for that is that the wrapping of dart tests doesn't work in all
> situations (see http://dartbug.com/2264).

We should reword the warning to inform the user that the test should be marked
as failing with a reference to bug 2264.

Powered by Google App Engine
This is Rietveld 408576698