Issue 11886061: Mark isolate2_negative_test as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11886061: Mark isolate2_negative_test as flaky. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark isolate2_negative_test as flaky. Committed: https://code.google.com/p/dart/source/detail?r=17125

Patch Set 2 : Really mark it as flaky. #

Total comments: 2

Patch Set 3 : Move test to $browser. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/isolate/isolate.status	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Thanks Florian! https://codereview.chromium.org/11886061/diff/2001/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://codereview.chromium.org/11886061/diff/2001/tests/isolate/isolate.status#newcode93 tests/isolate/isolate.status:93: [ $compiler == dart2js && ($runtime == ...

7 years, 11 months ago (2013-01-16 08:56:50 UTC) #2

floitsch

7 years, 11 months ago (2013-01-16 09:03:37 UTC) #4

https://codereview.chromium.org/11886061/diff/2001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/11886061/diff/2001/tests/isolate/isolate.stat...
tests/isolate/isolate.status:93: [ $compiler == dart2js && ($runtime == drt ||
$runtime == chrome || ($runtime == ff && $system == linux)) ]
On 2013/01/16 08:56:50, ngeoffray wrote:
> Actually I'm not even sure about this line. You can remove it and let the
fail,
> pass be under [ $compiler == dart2js && $browser ].

Done.