Issue 11886044: Set statically known ResultCid for AllocateObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11886044: Set statically known ResultCid for AllocateObject. (Closed)

Created:
7 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set statically known ResultCid for AllocateObject. Specialize PolymorphicInstanceCall in ApplyClassIds if receiver cid was infered: filter out all but one target for attached ICData and drop checks. Canonicalize away CheckClass if reciever cid matches at least one in the list of checked. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17079

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -7 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+49 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+7 lines, -1 line	1 comment	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 11 months ago (2013-01-15 13:46:58 UTC) #2

LGTM.

https://codereview.chromium.org/11886044/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.h (right):

https://codereview.chromium.org/11886044/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.h:56: void
SpecializePolymophicInstanceCall(PolymorphicInstanceCallInstr* call);
/s/Polymophic/Polymorphic/g

https://codereview.chromium.org/11886044/diff/1/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://codereview.chromium.org/11886044/diff/1/runtime/vm/il_printer.cc#newc...
runtime/vm/il_printer.cc:131: f->Print(" <%p>",
static_cast<void*>(target.raw()));
use Px instead?

Expand Messages | Collapse Messages