Issue 11886038: Change the WebSocket implementation to use Socket.read instead of Socket.readList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11886038: Change the WebSocket implementation to use Socket.read instead of Socket.readList (Closed)

Created:
7 years, 11 months ago by Søren Gjesse

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the WebSocket implementation to use Socket.read instead of Socket.readList This removes the need for Socket.available which is not implemented for SecureSocket. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17047

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -14 lines)			Patch
M	sdk/lib/io/websocket_impl.dart	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	tests/standalone/io/web_socket_protocol_processor_test.dart	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
A	tests/standalone/io/web_socket_secure_test.dart	View	1	1 chunk	+63 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

7 years, 11 months ago (2013-01-15 08:40:20 UTC) #4

Message was sent while issue was closed.

LGTM!

https://codereview.chromium.org/11886038/diff/1002/tests/standalone/io/web_so...
File tests/standalone/io/web_socket_secure_test.dart (right):

https://codereview.chromium.org/11886038/diff/1002/tests/standalone/io/web_so...
tests/standalone/io/web_socket_secure_test.dart:16: // Create a web socket
handler and set is as the HTTP server default
is as -> it as

Expand Messages | Collapse Messages