Issue 11884029: Upload new Dart binaries and re-enable unit tests for test scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11884029: Upload new Dart binaries and re-enable unit tests for test scripts. (Closed)

Created:
7 years, 11 months ago by Bill Hesse

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Upload new Dart binaries and re-enable unit tests for test scripts. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17031

Patch Set 2 : Change Futures.wait to Future.wait in two test script files. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -23 lines)			Patch
M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/release/version.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/windows/dart.exe	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/dart/co19_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/drt_updater.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/http_server.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	tools/testing/dart/multitest.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/version.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/11884029/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/11884029/diff/1/tools/testing/dart/multitest.dart#newcode220 tools/testing/dart/multitest.dart:220: String baseFilename = filePath.filenameWithoutExtension; Futures needs to be changed ...

7 years, 11 months ago (2013-01-14 20:39:59 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 11884029: Upload new Dart binaries and re-enable unit tests for test scripts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Change Futures.wait to Future.wait in two test script files. #

Messages