Detect if webkitNotifications is available and remove webkit prefix (replaced

Detect if webkitNotifications is available and remove webkit prefix (replaced
with "experimental").

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17105

[Emily Fortuna, 2013-01-15 00:54:25]

https://codereview.chromium.org/11883025/diff/10002/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/11883025/diff/10002/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:883: -   * Returns a data URI containing
a representation of the image in the
sorry this diff is a mess. Look at the html_dartium for a diff of what's really
changed. :-/

[blois, 2013-01-15 01:31:56]

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
File tests/html/exceptions_test.dart (right):

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
tests/html/exceptions_test.dart:11: expect(NotificationCenter.supported, true);
This should probably go in a separate notifications test, that also validates
that it fails if not supported.

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
tests/html/exceptions_test.dart:26: test('EventException', () {
seems like this test should not be included in the notification supported
section.

[Emily Fortuna, 2013-01-15 02:21:06]

PTAL

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
File tests/html/exceptions_test.dart (right):

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
tests/html/exceptions_test.dart:11: expect(NotificationCenter.supported, true);
On 2013/01/15 01:31:56, blois wrote:
> This should probably go in a separate notifications test, that also validates
> that it fails if not supported.

Done.

https://codereview.chromium.org/11883025/diff/10002/tests/html/exceptions_tes...
tests/html/exceptions_test.dart:26: test('EventException', () {
On 2013/01/15 01:31:56, blois wrote:
> seems like this test should not be included in the notification supported
> section.

Done.

[blois, 2013-01-15 18:20:56]

https://codereview.chromium.org/11883025/diff/6002/tests/html/notifications_t...
File tests/html/notifications_test.dart (right):

https://codereview.chromium.org/11883025/diff/6002/tests/html/notifications_t...
tests/html/notifications_test.dart:28: expect(e.code,
DomException.SECURITY_ERR);
My understanding is that e.code is deprecated and may be Chrome only. If so,
should we remove it?

https://codereview.chromium.org/11883025/diff/6002/tests/html/notifications_t...
tests/html/notifications_test.dart:30: expect(e.message, 'SecurityError: DOM
Exception 18');
I believe that message may be localized. Not sure we can rely on it.

[Emily Fortuna, 2013-01-15 22:30:39]

PTAL. Also, Safari 6 still returns SECURITY_ERR, which is not the standard (the
nightly builds have this fixed). I'm not sure if adding another supported check
is the right thing to do in this case, though? What do you suggest?

I removed all the DomException code constants, since they're deprecated.

[blois, 2013-01-15 22:37:04]

lgtm

I'd either loosen up the test to pass on Safari or special-case Safari behavior
for Safari. Then open a bug to tighten it back down.

[Emily Fortuna, 2013-01-15 23:12:11]

On 2013/01/15 22:37:04, blois wrote:
> lgtm
> 
> I'd either loosen up the test to pass on Safari or special-case Safari
behavior
> for Safari. Then open a bug to tighten it back down.

FYI -- I polyfilled the name for Safari (duh!) :-) Looks like it's only
SecurityError that was different, but I can add others as we encounter them.

[blois, 2013-01-15 23:14:35]

lgtm