Issue 11882005: Fix performance of array literals (e.g. "[1, 2]"). Improves speed of DeltaBlue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11882005: Fix performance of array literals (e.g. "[1, 2]"). Improves speed of DeltaBlue. (Closed)

Created:
7 years, 11 months ago by srdjan

Modified:
7 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix performance of array literals (e.g. "[1, 2]"). Improves speed of DeltaBlue. Simplify code to allocate groable object array from an object array. Committed: https://code.google.com/p/dart/source/detail?r=16999

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	runtime/lib/array_patch.dart	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/11882005/diff/2001/runtime/lib/array_patch.dart File runtime/lib/array_patch.dart (right): https://codereview.chromium.org/11882005/diff/2001/runtime/lib/array_patch.dart#newcode52 runtime/lib/array_patch.dart:52: result._setLength(elements.length); This is confusing. Please update as discussed.

7 years, 11 months ago (2013-01-11 23:15:58 UTC) #2

LGTM -ip

Expand Messages | Collapse Messages