Correctly implement co19 test suite.

Correctly implement co19 test suite.

Committed: https://code.google.com/p/dart/source/detail?r=17204

[ahe, 2013-01-15 16:52:52]

Now with side-by-side diff.

[kustermann, 2013-01-15 17:11:08]

https://codereview.chromium.org/11881053/diff/7002/dart/tools/testing/dart/te...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11881053/diff/7002/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_suite.dart:1458: "containsSourceOrImport": false
I think 'numStaticTypeAnnotations' and 'numCompileTimeAnnotations' is missing
here?

[ricow1, 2013-01-16 09:45:13]

Is this done to explicitly enforce certain constraints on what is possible in
the co19 tests?
Otherwise: why do we need specialized handling?

[ahe, 2013-01-16 10:22:34]

On 2013/01/16 09:45:13, ricow1 wrote:
> Is this done to explicitly enforce certain constraints on what is possible in
> the co19 tests?

Yes. For two reasons:

* The team at Unipro discovered dubious features that had been added for
dart_analyzer. This causes problems because the co19 tests are then no longer
following the co19 specification (a design document).

* The dart_analyzer team had removed features that the co19 test suite needed. I
think it is obvious why that is a problem.

[ricow1, 2013-01-16 10:29:27]

On 2013/01/16 10:22:34, ahe wrote:
> On 2013/01/16 09:45:13, ricow1 wrote:
> > Is this done to explicitly enforce certain constraints on what is possible
in
> > the co19 tests?
> 
> Yes. For two reasons:
> 
> * The team at Unipro discovered dubious features that had been added for
> dart_analyzer. This causes problems because the co19 tests are then no longer
> following the co19 specification (a design document).
> 
> * The dart_analyzer team had removed features that the co19 test suite needed.
I
> think it is obvious why that is a problem.
Maybe add a short comment in the file as to why we do this, other than that LGTM

[ahe, 2013-01-16 12:15:01]

PTAL

[kustermann, 2013-01-16 14:23:44]

lgtm

[ahe, 2013-01-17 12:00:29]

PTAL

[kustermann, 2013-01-17 13:22:45]

lgtm