Issue 11880036: Removing HTML elements by making them private.

Issue 11880036: Removing HTML elements by making them private. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski

Modified:
7 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, antonm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing HTML elements by making them private. Committed: https://code.google.com/p/dart/source/detail?r=17099

Patch Set 3 : Working! #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -31 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2	2 chunks	+8 lines, -11 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+12 lines, -20 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/11880036/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11880036/diff/1/tools/dom/scripts/htmlrenamer.py#newcode17 tools/dom/scripts/htmlrenamer.py:17: 'HTMLDirectoryElement' : '_DirectoryElement', Should also add HTMLDirectoryElement.* to _removed_html_members.

7 years, 11 months ago (2013-01-14 23:21:53 UTC) #2

Andrei Mouravski

PTAL. https://codereview.chromium.org/11880036/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11880036/diff/1/tools/dom/scripts/htmlrenamer.py#newcode17 tools/dom/scripts/htmlrenamer.py:17: 'HTMLDirectoryElement' : '_DirectoryElement', On 2013/01/14 23:21:53, blois wrote: ...

7 years, 11 months ago (2013-01-14 23:54:23 UTC) #3

lgtm

Expand Messages | Collapse Messages