- Start adding meta data for fields of VM internal classes.

- Start adding meta data for fields of VM internal classes.
- Correctly report instance size in bytes.
- At least report field sizes for variable sized objects.
Committed: https://code.google.com/p/dart/source/detail?r=16996

[cshapiro, 2013-01-11 21:23:20]

LGTM with comments

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc#newcode509
runtime/vm/object.cc:509: name = Symbols::New("parent _");
Maybe use @ instead of ' ' in the identifier so we can have a single token to
distinguish private names.

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc#newcode512
runtime/vm/object.cc:512: cls. SetFields(fields);
Horizontal space!

[Ivan Posva, 2013-01-11 23:05:37]

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc#newcode509
runtime/vm/object.cc:509: name = Symbols::New("parent _");
On 2013/01/11 21:23:21, cshapiro wrote:
> Maybe use @ instead of ' ' in the identifier so we can have a single token to
> distinguish private names.

Done.

https://codereview.chromium.org/11880004/diff/1/runtime/vm/object.cc#newcode512
runtime/vm/object.cc:512: cls. SetFields(fields);
On 2013/01/11 21:23:21, cshapiro wrote:
> Horizontal space!

Done.

[siva, 2013-01-11 23:26:42]

lgtm