Issue 11879047: Add a new class InvokeDynamicSpecializer and subclasses that know what input types are beneficial f…

Issue 11879047: Add a new class InvokeDynamicSpecializer and subclasses that know what input types are beneficial f… (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a new class InvokeDynamicSpecializer and subclasses that know what input types are beneficial for optimization, and know how to change a HInvokeDynamicMethod to a builtin instruction. Committed: https://code.google.com/p/dart/source/detail?r=17126

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -83 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2	2 chunks	+7 lines, -10 lines	0 comments	Download
A	sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart	View		1 chunk	+173 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1 2	2 chunks	+10 lines, -51 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1 2	1 chunk	+3 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/ssa.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2906 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2906: node, selector, receiver, inputs); That's a lot of ...

7 years, 11 months ago (2013-01-16 07:26:03 UTC) #2

ngeoffray

7 years, 11 months ago (2013-01-16 09:02:54 UTC) #3

Thanks Kasper.

https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2906: node, selector,
receiver, inputs);
On 2013/01/16 07:26:03, kasperl wrote:
> That's a lot of indentation.

Done.

https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3643: bool
isIntercepted = interceptedClasses != null;
On 2013/01/16 07:26:03, kasperl wrote:
> I guess the set cannot be empty?

Indeed, it cannot be empty, I added an assert.

https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/im...
File
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart
(right):

https://codereview.chromium.org/11879047/diff/5/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart:5:
part of ssa;
On 2013/01/16 07:26:03, kasperl wrote:
> Nit: Maybe we should start using more structured names for our libraries. This
> one would read better as dart2js.ssa.

Agree. Let's keep that in mind and do an overall rename next.

Expand Messages | Collapse Messages