Issue 11879039: Fix error message for library name mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11879039: Fix error message for library name mismatch. (Closed)

Created:
7 years, 11 months ago by Johnni Winther

Modified:
7 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix error message for library name mismatch. Committed: https://code.google.com/p/dart/source/detail?r=17560

Patch Set 3 : Unittest added. #

Total comments: 2

Patch Set 4 : Updated cf. comment. #

Patch Set 5 : Rebased #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/compiler/dart2js/part_of_test.dart	View	1 2 3	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, but I'd like to have a test. If that is hard, we should make ...

7 years, 11 months ago (2013-01-21 11:05:33 UTC) #2

ahe

LGTM! https://codereview.chromium.org/11879039/diff/4002/tests/compiler/dart2js/part_of_test.dart File tests/compiler/dart2js/part_of_test.dart (right): https://codereview.chromium.org/11879039/diff/4002/tests/compiler/dart2js/part_of_test.dart#newcode35 tests/compiler/dart2js/part_of_test.dart:35: Expect.equals('Warning: expected part of library name "foo".', Could ...

7 years, 11 months ago (2013-01-23 11:30:26 UTC) #3

Johnni Winther

7 years, 11 months ago (2013-01-24 13:13:18 UTC) #4

https://codereview.chromium.org/11879039/diff/4002/tests/compiler/dart2js/par...
File tests/compiler/dart2js/part_of_test.dart (right):

https://codereview.chromium.org/11879039/diff/4002/tests/compiler/dart2js/par...
tests/compiler/dart2js/part_of_test.dart:35: Expect.equals('Warning: expected
part of library name "foo".',
On 2013/01/23 11:30:27, ahe wrote:
> Could you obtain this string with:
> 
> "${MessageKind.LIBRARY_NAME_MISMATCH.error(['foo'])}"

Done.