Issue 11879008: Emit fake classes to please the third party HPROF tool infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11879008: Emit fake classes to please the third party HPROF tool infrastructure. (Closed)

Created:
7 years, 11 months ago by cshapiro

Modified:
7 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit fake classes to please the third party HPROF tool infrastructure. Committed: https://code.google.com/p/dart/source/detail?r=17005

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : address review comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -3 lines)			Patch
	M	runtime/vm/heap_profiler.h	View	1 2	3 chunks	+23 lines, -2 lines	0 comments	Download
	M	runtime/vm/heap_profiler.cc	View	1 2	4 chunks	+62 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

7 years, 11 months ago (2013-01-12 00:58:09 UTC) #2

LGTM with comment.

-Ivan

https://codereview.chromium.org/11879008/diff/1003/runtime/vm/heap_profiler.h
File runtime/vm/heap_profiler.h (right):

https://codereview.chromium.org/11879008/diff/1003/runtime/vm/heap_profiler.h...
runtime/vm/heap_profiler.h:77: enum FakeClass {
Comment about spacing the ids.

https://codereview.chromium.org/11879008/diff/1003/runtime/vm/heap_profiler.h...
runtime/vm/heap_profiler.h:90: kArrayLong = 98
97

Expand Messages | Collapse Messages