Issue 11878017: Extract SourceFile aware provider/handler.

Issue 11878017: Extract SourceFile aware provider/handler. (Closed)

Created:
7 years, 11 months ago by Johnni Winther

Modified:
7 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract SourceFile aware provider/handler. Committed: https://code.google.com/p/dart/source/detail?r=17444

Patch Set 3 : Updated cf. comments. #

Total comments: 2

Patch Set 5 : Updated cf. comment. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -100 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View	1 2	12 chunks	+26 lines, -100 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	sdk/lib/_internal/compiler/implementation/source_file_provider.dart	View	1 2 3 4	1 chunk	+121 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Currently, the compiler API takes two arguments, called "provider" and "handler". These names are not ...

7 years, 11 months ago (2013-01-21 11:29:52 UTC) #2

Johnni Winther

PTAL https://codereview.chromium.org/11878017/diff/8001/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/11878017/diff/8001/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode8 sdk/lib/_internal/compiler/implementation/dart2js.dart:8: import 'dart:collection' show Queue, LinkedHashMap; From rebase.

7 years, 11 months ago (2013-01-23 08:02:35 UTC) #3

ahe

7 years, 11 months ago (2013-01-23 09:16:06 UTC) #4

LGTM!

https://codereview.chromium.org/11878017/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/source_file_provider.dart
(right):

https://codereview.chromium.org/11878017/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/source_file_provider.dart:77: //
TODO(johnniwinther): Remove this when source map is handled differently.
You can use my name here. I have a CL to remove this.

Expand Messages | Collapse Messages