Issue 11878006: Fix printing of the function that cannot be optimized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11878006: Fix printing of the function that cannot be optimized. (Closed)

Created:
7 years, 11 months ago by srdjan

Modified:
7 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix printing of the function that cannot be optimized. Committed: https://code.google.com/p/dart/source/detail?r=16997

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -38 lines)			Patch
	M	runtime/vm/code_generator.cc	View	1	18 chunks	+38 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/11878006/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11878006/diff/1/runtime/vm/code_generator.cc#newcode1386 runtime/vm/code_generator.cc:1386: OS::Print("Not Optimizable: %s\n", function.ToFullyQualifiedCString()); We could start using ...

7 years, 11 months ago (2013-01-11 23:08:13 UTC) #2

srdjan

7 years, 11 months ago (2013-01-11 23:12:08 UTC) #3

Switched all OS::Print to OS::PrintErr inside code_generator.cc

Expand Messages | Collapse Messages

Issue 11878006: Fix printing of the function that cannot be optimized. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages