Issue 11876012: Fix minor path handling issue in path package.

Issue 11876012: Fix minor path handling issue in path package. (Closed)

Created:
7 years, 11 months ago by Emily Fortuna

Modified:
7 years, 11 months ago

Reviewers:
Bob Nystrom, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix minor path handling issue in path package. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17006

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	pkg/path/lib/path.dart	View	1 2	2 chunks	+12 lines, -4 lines	0 comments	Download
	M	pkg/path/test/path_windows_test.dart	View		4 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm % one minor comment https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart File pkg/path/lib/path.dart (right): https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart#newcode444 pkg/path/lib/path.dart:444: ((fromParsed.root == null || ...

7 years, 11 months ago (2013-01-12 23:36:01 UTC) #2

Jennifer Messerly

https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart File pkg/path/lib/path.dart (right): https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart#newcode652 pkg/path/lib/path.dart:652: if (root != null && !root.startsWith('//') && style == ...

7 years, 11 months ago (2013-01-12 23:37:50 UTC) #3

Emily Fortuna

7 years, 11 months ago (2013-01-12 23:43:32 UTC) #4

https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart
File pkg/path/lib/path.dart (right):

https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart#new...
pkg/path/lib/path.dart:444: ((fromParsed.root ==  null || pathParsed.root == 
null) ||
On 2013/01/12 23:36:01, John Messerly wrote:
> looks like an extra space after == ?

Done.

https://codereview.chromium.org/11876012/diff/2001/pkg/path/lib/path.dart#new...
pkg/path/lib/path.dart:652: if (root != null && !root.startsWith('//') && style
== Style.windows) {
On 2013/01/12 23:37:50, John Messerly wrote:
> On 2013/01/12 23:36:01, John Messerly wrote:
> > I think we do want to normalize UNC to r"\\" as well:
> > http://en.wikipedia.org/wiki/Path_%2528computing%2529#UNC_in_Windows
> 
> oops wrong link. this one is better:
> http://en.wikipedia.org/wiki/Path_%28computing%29#Uniform_Naming_Convention

Done.

Expand Messages | Collapse Messages